Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Include/Exclude Lists #56

Closed
vrajat opened this issue Feb 5, 2020 · 13 comments · Fixed by #58
Closed

Support Include/Exclude Lists #56

vrajat opened this issue Feb 5, 2020 · 13 comments · Fixed by #58

Comments

@vrajat
Copy link
Member

vrajat commented Feb 5, 2020

Athena is working for shallow type scan. For deep scan it throws below error:
HIVE_UNKNOWN_ERROR: All access to this object has been disabled (Service: Amazon S3; Status Code: 403; Error Code: AllAccessDisabled; Request ID:

Is there any parameter in config where we can pass specific DB to scan ?

Originally posted by @jayeshagwan1 in #55 (comment)

@jayeshagwan1
Copy link

Thanks. Parameter in config will work na ?

@vrajat vrajat closed this as completed in f66b692 Feb 10, 2020
@jayeshagwan1
Copy link

I tried providing schema and table name to check if it works. I am getting error :

raise OperationalError(query_execution.state_change_reason) pyathena.error.OperationalError: SYNTAX_ERROR: line 1:8: Column 'request_timestamp' cannot be resolved

I don't request_timestamp column.

@vrajat
Copy link
Member Author

vrajat commented Feb 10, 2020

I just merged it to master. Can you downloading the code and run python setup.py develop in virtualenv ?

--help should provide enough docs. Config files are also supported

@jayeshagwan1
Copy link

After python setup.py develop, tried running help, but not getting updated help:

image

@vrajat
Copy link
Member Author

vrajat commented Feb 10, 2020

oh - can you try piicatcher db --help ? I have forgotten to support it in aws. I'll add it asap

@jayeshagwan1
Copy link

jayeshagwan1 commented Feb 10, 2020

My config, I added
list_all=True
schema="temp"
table="pii_data"

Tried running with config:

image

@vrajat
Copy link
Member Author

vrajat commented Feb 10, 2020

Yea- I forgot to add it to aws. Fixing that now.

@jayeshagwan1
Copy link

piicatcher db --help

For db its working fine 👍
image

Also is the above mentioned params for config are correct ?

@vrajat
Copy link
Member Author

vrajat commented Feb 10, 2020

yes. config looks good.

@vrajat vrajat reopened this Feb 10, 2020
vrajat pushed a commit to vrajat/piicatcher that referenced this issue Feb 10, 2020
Support was missed in previous commit.

Again - fix tokern#56
vrajat added a commit that referenced this issue Feb 10, 2020
Support was missed in previous commit.

Again - fix #56
@jayeshagwan1
Copy link

Getting below error:
current_schema.tables.append(current_table) AttributeError: 'Schema' object has no attribute 'tables'

@vrajat
Copy link
Member Author

vrajat commented Feb 10, 2020

is there a line number ? Stack trace ?

@jayeshagwan1
Copy link

image

@vrajat
Copy link
Member Author

vrajat commented Feb 10, 2020

I found a gap in my testing. I'll add a test and fix the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants