Fix warnings for cloning references in generated code (#1676)

tokio-rs · Jan 5, 2023 · b6c282a · b6c282a
1 parent 2d8242b
commit b6c282a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/axum-macros/src/from_ref.rs b/axum-macros/src/from_ref.rs
@@ -3,7 +3,7 @@ use quote::quote_spanned;
 use syn::{
     parse::{Parse, ParseStream},
     spanned::Spanned,
-    Field, ItemStruct, Token,
+    Field, ItemStruct, Token, Type,
 };
 
 use crate::attr_parsing::{combine_unary_attribute, parse_attrs, Combine};
@@ -30,7 +30,11 @@ fn expand_field(state: &Ident, idx: usize, field: &Field) -> TokenStream {
     let span = field.ty.span();
 
     let body = if let Some(field_ident) = &field.ident {
-        quote_spanned! {span=> state.#field_ident.clone() }
+        if matches!(field_ty, Type::Reference(_)) {
+            quote_spanned! {span=> state.#field_ident }
+        } else {
+            quote_spanned! {span=> state.#field_ident.clone() }
+        }
     } else {
         let idx = syn::Index {
             index: idx as _,

diff --git a/axum-macros/tests/from_ref/pass/reference-types.rs b/axum-macros/tests/from_ref/pass/reference-types.rs
@@ -0,0 +1,10 @@
+#![deny(noop_method_call)]
+
+use axum_macros::FromRef;
+
+#[derive(FromRef)]
+struct State {
+    inner: &'static str,
+}
+
+fn main() {}