-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graceful shutdown does not shutdown when i use Google Chrome。 #2611
Comments
I've been able to reproduce it. It's true that chrome keeps the connection open even after the user has closed the site. However, it's true I can see you've already opened a bug in hyper which I believe is the right place. |
Should be fixed by hyperium/hyper-util#101 once that's out. |
still encountering this in chromium Version 123.0.6312.86, i think its not in the release version yet?
|
@estnml can you try running In either case please do share the version and if update helped. |
hi @mladedav output of "cargo tree | grep hyper" : │ ├── hyper v1.2.0 i did run cargo update but versions not changed |
The fix in hyper-util is merged to master, but hasn't been released yet, for what I can see. |
Is there any way we can hot-fix or workaround this bug before hyper-util is updated and released? |
You can patch your dependencies with the unreleased version of |
Thanks! This works, but the current master branch of
|
hyper-util 0.1.4 is released! |
There's nothing axum needs to do. You can remove the patch section, |
Hello @jplatte . The
Repeating with |
@pac-work Mind opening a new issue? |
Bug Report
Version
axum 0.7.4
Platform
macOs Big Sur 11.5.1
Crates
Description
After clone axum source code, run the following command
When the server is up, do the follows in Geegle Chrome:
1.open the serving page http://127.0.0.1:3000/ in browser (this is a must step to reproduce the problem)
2.go back to your terminal and press ctrl+c to stop the server
3.and you see that the server is hanging up but not stop even after a long time
4.After closing Google Chrome, the server shuts down immediately.
this is the log.
I found that when Google Chrome initiates a request, it creates two connections. After the request is completed, only one connection is closed, but the other connection remains active。
The following is the request log sent using Safari browser or Postman. You can see that the server shuts down normally, and there is only one connection initiated for each request sent by the browser.
How can I ensure that Google Chrome also doesn't encounter such an issue? It seems like this problem could lead to the server being unable to shut down for extended periods, which appears to be a bug.
The text was updated successfully, but these errors were encountered: