Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Clone requirements even if using Router::with_state_arc #1329

Merged
merged 2 commits into from Aug 26, 2022
Merged

Clarify Clone requirements even if using Router::with_state_arc #1329

merged 2 commits into from Aug 26, 2022

Conversation

davidpdrsn
Copy link
Member

Its a bit tricky to explain succinctly but hopefully this clears up that Router::with_state_arc doesn't let you bypass the Clone requirement.

Fixes #1321

@davidpdrsn davidpdrsn added T-docs Topic: documentation A-axum labels Aug 25, 2022
@davidpdrsn davidpdrsn enabled auto-merge (squash) August 25, 2022 21:33
@davidpdrsn davidpdrsn merged commit eb6451c into main Aug 26, 2022
@davidpdrsn davidpdrsn deleted the expand-with-state-arc-docs branch August 26, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
A-axum T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Router::with_state_arc might be misleading
2 participants
@davidpdrsn @jplatte