Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add must_use attribute to Redirect type #1356

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Sep 7, 2022

Motivation

I just had somebody ask me for help with a redirect that wasn't working, turns out they just didn't return the Redirect from the handler.

Solution

Have the compiler emit a warning if a Redirect goes unused.

@davidpdrsn davidpdrsn merged commit da4ea4d into main Sep 7, 2022
@davidpdrsn davidpdrsn deleted the jplatte/must-use-redirect branch September 7, 2022 11:52
jplatte added a commit that referenced this pull request Oct 19, 2022
jplatte added a commit that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants