Internally Arc Router

[davidpdrsn]

Based on #2473.

With Router being Sync we can now store it as an Arc internally which should help a lot with cloning it.

This might impact #2449.

TODO

• Changelog
• Benchmark it and see if there is a difference

[jplatte]

Nice, do we have any benchmarks to check the before/after for?

edit: Oh I see you have a TODO for that in the PR description.

[davidpdrsn]

Nice, do we have any benchmarks to check the before/after for?

Yeah we have some benchmarks in this repo. I'm gonna try and run them. Also curious if it impacts #2449

[jplatte]

Code looks good, curious about the benchmark results!

[davidpdrsn]

Tested with cargo bench -- routing which runs a benchmark of a router with 1000 routes.

On main:

Running "routing" benchmark
  Beginning round 1...
  Benchmarking 10 connections @ http://0.0.0.0:60849/foo/bar/baz for 10 second(s)
    Latencies:
      Avg      Stdev    Min      Max
      0.19ms   0.06ms   0.09ms   2.07ms
    Requests:
      Total: 515851  Req/Sec: 51581.42
    Transfer:
      Total: 36.90 MB Transfer Rate: 3.69 MB/Sec

On this branch

Running "routing" benchmark
  Beginning round 1...
  Benchmarking 10 connections @ http://0.0.0.0:60837/foo/bar/baz for 10 second(s)
    Latencies:
      Avg      Stdev    Min      Max
      0.07ms   0.02ms   0.01ms   0.77ms
    Requests:
      Total: 1366847 Req/Sec: 136678.29
    Transfer:
      Total: 97.76 MB Transfer Rate: 9.78 MB/Sec

So went from 51.581 rps to 136.678. Thats pretty nuts 😅

[jplatte]

Your dots in those numbers are in a weird position but yay 😄

Maybe we should look into running some benches in CI (measuring instruction counts for reproducibility) to catch obvious regressions in perf?

[davidpdrsn]

Your dots in those numbers are in a weird position but yay 😄

lol sorry about that 😂

Maybe we should look into running some benches in CI (measuring instruction counts for reproducibility) to catch obvious regressions in perf?

Never tried something like that but worth a shot!

[jplatte]

Superseded by #2483, right?

[davidpdrsn]

Yes!

Not sure if we still require Sync for services or if the mutex approach is fine.