Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unnecessary link targets #2778

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Conversation

mladedav
Copy link
Contributor

@mladedav mladedav commented Jun 9, 2024

Motivation

CI is emitting warnings due to unnecessary links in docs due to #[warn(rustdoc::redundant_explicit_links)] which is on by default.

Solution

Remove the unnecessary links. Each changed file is currently included from only a single place so this is ok.

Alternatives

Suppress this warning.

@mladedav
Copy link
Contributor Author

mladedav commented Jun 9, 2024

This will not actually fix the CI as noted here. But we might want to get rid of these warnings nonetheless either by doing this or suppressing the lint.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but I can't merge because of the CI issue 😉

edit: Oh, I can actually. Still would be nice to fix that of course.

@jplatte jplatte merged commit 7d43b46 into tokio-rs:main Jun 9, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants