Implement FromRequest for http::request::Parts
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its a convenient way to extract everything from a request except the body. Also makes sense for axum to provide this since other crates can't.
davidpdrsn
force-pushed
the
extract-request-parts
branch
from
b88e0cf
to
484fcb3
Compare
jplatte
approved these changes
Nov 9, 2021
Comment on lines
+340
to
+347
| let mut temp_request = Request::new(()); | ||
| *temp_request.method_mut() = method; | ||
| *temp_request.uri_mut() = uri; | ||
| *temp_request.version_mut() = version; | ||
| *temp_request.headers_mut() = headers; | ||
| *temp_request.extensions_mut() = extensions; | ||
|
|
||
| let (parts, _) = temp_request.into_parts(); |
There was a problem hiding this comment.
It's unfortunate that there is no way to exhaustively create request::Parts.
Merged
davidpdrsn
added a commit
that referenced
this pull request
Nov 13, 2021
EdorianDark
pushed a commit
to EdorianDark/axum
that referenced
this pull request
Nov 24, 2021
Its a convenient way to extract everything from a request except the body. Also makes sense for axum to provide this since other crates can't.
EdorianDark
pushed a commit
to EdorianDark/axum
that referenced
this pull request
Nov 24, 2021
- Implement `FromRequest` for [`http::request::Parts`] so it can be used an extractor ([tokio-rs#489]) - Implement `IntoResponse` for `http::response::Parts` ([tokio-rs#490]) [tokio-rs#489]: tokio-rs#489 [tokio-rs#490]: tokio-rs#490 [`http::request::Parts`]: https://docs.rs/http/latest/http/request/struct.Parts.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its a convenient way to extract everything from the request except the
body. Also makes sense for axum to provide this since other crates
can't.