Implement tower::Layer for Extension
#801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
approved these changes
Feb 28, 2022
davidpdrsn
added a commit
that referenced
this pull request
Feb 28, 2022
davidpdrsn
added a commit
that referenced
this pull request
Mar 1, 2022
* Implement `tower::Layer` for `Extension` (#801) * Implement `tower::Layer` for `Extension` * changelog * Deprecate `AddExtensionLayer` * changelog * Add missing #[allow(deprecated)]
davidpdrsn
added a commit
that referenced
this pull request
Mar 1, 2022
Merged
davidpdrsn
added a commit
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #797
Extensioncan actually implementtower::Layer. This means users only need to know one type to apply the extensions and extract them. Makes the API a bit smaller.I think I'm gonna backport this with a deprecation for
AddExtensionLayer, and then remove it onmain. I'll do that when this is merged.