Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how BytesMut::zeroed works and advantages to manual impl #714

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Clarify how BytesMut::zeroed works and advantages to manual impl #714

merged 2 commits into from
Jun 21, 2024

Conversation

paolobarbolini
Copy link
Contributor

Fixes #713

@paolobarbolini paolobarbolini mentioned this pull request Jun 19, 2024
Closed
Darksonn
Darksonn reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wording nit.

src/bytes_mut.rs Outdated Show resolved Hide resolved
@paolobarbolini @Darksonn
Update src/bytes_mut.rs
8c21a95 
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Darksonn
Darksonn approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn merged commit 7a5154b into tokio-rs:master Jun 21, 2024
15 checks passed
@mox692 mox692 mentioned this pull request Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BytesMut::zeroed doc header improvement
2 participants
@paolobarbolini @Darksonn