Skip to content

Commit

Permalink
feat(console-api): Update tonic to 0.7 (#318)
Browse files Browse the repository at this point in the history
This change updates `tonic` and `prost` to their latest versions. In
addition this PR changes how the generated protobuf is built from being
done in a `build.rs` file to a `tests/boostrap.rs` test. This removes
the need for downstream consumers to compile/provide `protoc` for
`prost` to generate the protobuf files (which was changed in `0.10`).

The bootstrap test will first attempt to compile the protobuf files and
check if there is a git diff between the checked in version. If there is
a difference it will fail the test waiting for the files to be checked
in. This will fail PRs that have updated the protobuf files but not
checked in the new versions.

BREAKING CHANGE: 
`console-api` is now no longer compatible with projects using `prost`
0.9 or `tonic` 0.7. These crates must be updated to use `console-api`
0.2.
  • Loading branch information
LucioFranco committed Apr 8, 2022
1 parent 9178ecf commit 83d8a87
Show file tree
Hide file tree
Showing 19 changed files with 1,887 additions and 272 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/ci.yaml
Expand Up @@ -25,11 +25,9 @@ env:
RUSTUP_MAX_RETRIES: 10
# Don't emit giant backtraces in the CI logs.
RUST_BACKTRACE: short
# Make Rust 1.56.0 the minimum supported Rust version.
#
# Some of our dependencies require `edition = "2021"` which is only supported
# on 1.56.0+.
minrust: 1.56.0
# Make 1.58 MSRV due to <=1.57 failing to build console-api due to a bug
# with cargo version resolution.
minrust: 1.58.0

jobs:
check:
Expand Down

0 comments on commit 83d8a87

Please sign in to comment.