Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix console-subscriber on tokio 1.21.0 #374

Merged
merged 3 commits into from Sep 4, 2022

Conversation

Noah-Kennedy
Copy link
Contributor

@Noah-Kennedy Noah-Kennedy commented Sep 3, 2022

Fixes #373.

Due to a change in the unstable task builder APIs, this no longer compiles with the latest version of Tokio.

Fortunately, it's a simple fix.

Due to a change in the unstable task builder APIs, this no longer compiles with the latest version of Tokio. Fortunately, it's a simple fix.
@Noah-Kennedy Noah-Kennedy requested a review from a team as a code owner September 3, 2022 22:05
@Noah-Kennedy
Copy link
Contributor Author

Ah, crap, need to fix CI.

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

It looks like CI is still broken because the examples also use task::Builder: #374 (comment)

Mind fixing them as well?

@Noah-Kennedy
Copy link
Contributor Author

I'll get these fixed tomorrow morning.

@Noah-Kennedy
Copy link
Contributor Author

Hmm, CI seems to be failing for things unrelated to this PR.

@Noah-Kennedy
Copy link
Contributor Author

Looks like Clippy lints.

@Noah-Kennedy
Copy link
Contributor Author

@hawkw should I fix those in another PR or in this one?

@hawkw
Copy link
Member

hawkw commented Sep 4, 2022

@hawkw should I fix those in another PR or in this one?

i'd prefer them to be fixed separately, but it's not a huge deal.

@Noah-Kennedy
Copy link
Contributor Author

That would be my preference as well, but I wanted to check with you first. I'll put up the PR shortly.

@Noah-Kennedy
Copy link
Contributor Author

@hawkw I've posted #375, which should fix this.

hawkw pushed a commit that referenced this pull request Sep 4, 2022
Needed for #374.

This configures clippy to ignore most of the generated code in
`console-api`.
@hawkw hawkw enabled auto-merge (squash) September 4, 2022 20:57
@Noah-Kennedy
Copy link
Contributor Author

Thanks for the review!

@hawkw hawkw merged commit 0106407 into tokio-rs:main Sep 4, 2022
@Noah-Kennedy Noah-Kennedy deleted the noah/fix-tokio-1.21 branch September 4, 2022 21:05
hawkw added a commit that referenced this pull request Sep 4, 2022
<a name="0.1.7"></a>
## 0.1.8 (2022-09-04)

#### Bug Fixes

*  fix build on tokio 1.21.0 (#374) ([0106407](0106407))
hawkw added a commit that referenced this pull request Sep 4, 2022
<a name="0.1.7"></a>
## 0.1.8 (2022-09-04)

#### Bug Fixes

*  fix build on tokio 1.21.0 (#374) ([0106407](0106407))
hawkw pushed a commit that referenced this pull request Sep 29, 2023
Needed for #374.

This configures clippy to ignore most of the generated code in
`console-api`.
hawkw pushed a commit that referenced this pull request Sep 29, 2023
Due to a change in the unstable task builder APIs, this no longer
compiles with the latest version of Tokio. Fortunately, it's a simple
fix.
hawkw added a commit that referenced this pull request Sep 29, 2023
<a name="0.1.7"></a>
## 0.1.8 (2022-09-04)

#### Bug Fixes

*  fix build on tokio 1.21.0 (#374) ([0106407](0106407))
hawkw added a commit that referenced this pull request Sep 29, 2023
# Changelog

All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## console-subscriber-v0.2.0 - (2023-09-29)

[0b0c1af](https://github.com/tokio-rs/console/commit/0b0c1aff18c3260d3a45a78f6c0d6f4206af1cbb)...[0b0c1af](https://github.com/tokio-rs/console/commit/0b0c1aff18c3260d3a45a78f6c0d6f4206af1cbb)

### <a id = "console-subscriber-v0.2.0-breaking"></a>Breaking Changes
- **Update Tonic and Prost dependencies ([#364](#364 ([f9b8e03](https://github.com/tokio-rs/console/commit/f9b8e03bd7ee1d0edb441c94a93a350d5b06ed3b))<br />This commit updates the public dependencies `prost` and `tonic` to
semver-incompatible versions (v0.11.0 and v0.8.0, respectively). This is
a breaking change for users who are integrating the `console-api` protos
with their own `tonic` servers or clients.
- **Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464 ([96e62c8](https://github.com/tokio-rs/console/commit/96e62c83ef959569bb062dc8fee98fa2b2461e8d))<br />This is a breaking change for users of `console-api` and
`console-subscriber`, as it changes the public `tonic` dependency to a
semver-incompatible version. This breaks compatibility with `tonic`
0.9.x and `prost` 0.11.x.

### Added

- [**breaking**](#console-subscriber-v0.2.0-breaking) Update Tonic and Prost dependencies ([#364](#364)) ([f9b8e03](f9b8e03))
- Add support for Unix domain sockets ([#388](#388)) ([a944dbc](a944dbc), closes [#296](#296))
- Add scheduled time per task ([#406](#406)) ([f280df9](f280df9))
- Add task scheduled times histogram ([#409](#409)) ([d92a399](d92a399))
- Update `tonic` to 0.9 ([#420](#420)) ([48af1ee](48af1ee))
- Update MSRV to Rust 1.60.0 ([b18ee47](b18ee47))
- Expose server parts ([#451](#451)) ([e51ac5a](e51ac5a))
- Add cfg `console_without_tokio_unstable` ([#446](#446)) ([7ed6673](7ed6673))
- Add warning for tasks that never yield ([#439](#439)) ([d05fa9e](d05fa9e))
- [**breaking**](#console-subscriber-v0.2.0-breaking) Update `tonic` to v0.10 and increase MSRV to 1.64 ([#464](#464)) ([96e62c8](96e62c8))

### Documented

- Fix unclosed code block ([#463](#463)) ([362bdbe](362bdbe))
- Update MSRV version docs to 1.64 ([#467](#467)) ([94a5a51](94a5a51))

### Fixed

- Fix build on tokio 1.21.0 ([#374](#374)) ([c34ac2d](c34ac2d))
- Fix off-by-one indexing for `callsites` ([#391](#391)) ([43891ab](43891ab))
- Bump minimum Tokio version ([#397](#397)) ([bbb8f25](bbb8f25), fixes [#386](#386))
- Fix self wakes count ([#430](#430)) ([d308935](d308935))
- Remove clock skew warning in `start_poll` ([#434](#434)) ([4a88b28](4a88b28))
- Do not report excessive polling ([#378](#378)) ([#440](#440)) ([8b483bf](8b483bf), closes [#378](#378))
- Correct retain logic ([#447](#447)) ([36ffc51](36ffc51))

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

console-subscriber build error vs tokio v1.21.0
2 participants