-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): use tokio task ids in task views #403
Merged
Merged
Commits on Mar 13, 2023
-
feat(console): use tokio task ids in task views
Tokio Console generates its own sequential Id for internal tracking and indexing of objects (tasks, resources, etc.). However, this Id will be recreated if Console is restarted. In order to provide more useful information to the user, the task Id generated by Tokio can be used in the task list and task details screens instead. If used in this way, the ID field in the task list and task detail views will be stable across restarts of Console (assuming the monitored application is not restarted). This also frees up horizontal space, as the `task.id` attribute doesn't need to be displayed separately. The disadvantage of using Tokio's task Id is that it is not guaranteed to be present by the type system. To avoid problems with missing task Ids, the Tokio task Id is store in addition to the `span::Id` (used to communicate with the `console-subscriber`) and the sequential console `Id` (used in the `store`). If a task is missing the `task.id` field for whatever reason it will still appear, but with an empty ID. If multiple runtimes are active, then duplicate ID values will appear. Fixes: #385
Configuration menu - View commit details
-
Copy full SHA for db7554a - Browse repository at this point
Copy the full SHA db7554aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e96be29 - Browse repository at this point
Copy the full SHA e96be29View commit details
Commits on Mar 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c5e9d69 - Browse repository at this point
Copy the full SHA c5e9d69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e52bc5 - Browse repository at this point
Copy the full SHA 5e52bc5View commit details
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2f2332e - Browse repository at this point
Copy the full SHA 2f2332eView commit details
Commits on Mar 27, 2023
-
Apply Eliza's suggestions from code review
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Configuration menu - View commit details
-
Copy full SHA for a14fb75 - Browse repository at this point
Copy the full SHA a14fb75View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2e00c1 - Browse repository at this point
Copy the full SHA d2e00c1View commit details
Commits on Mar 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ce5c111 - Browse repository at this point
Copy the full SHA ce5c111View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.