Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): use tokio task ids in task views #403

Merged
merged 8 commits into from
Mar 28, 2023

Commits on Mar 13, 2023

  1. feat(console): use tokio task ids in task views

    Tokio Console generates its own sequential Id for internal tracking and
    indexing of objects (tasks, resources, etc.). However, this Id will be
    recreated if Console is restarted.
    
    In order to provide more useful information to the user, the task Id
    generated by Tokio can be used in the task list and task details screens
    instead. If used in this way, the ID field in the task list and task
    detail views will be stable across restarts of Console (assuming the
    monitored application is not restarted).
    
    This also frees up horizontal space, as the `task.id` attribute
    doesn't need to be displayed separately.
    
    The disadvantage of using Tokio's task Id is that it is not guaranteed
    to be present by the type system.
    
    To avoid problems with missing task Ids, the Tokio task Id is store in
    addition to the `span::Id` (used to communicate with the
    `console-subscriber`) and the sequential console `Id` (used in the
    `store`). If a task is missing the `task.id` field for whatever reason
    it will still appear, but with an empty ID. If multiple runtimes are
    active, then duplicate ID values will appear.
    
    Fixes: #385
    hds committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    db7554a View commit details
    Browse the repository at this point in the history
  2. update clippy lint name

    hds committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e96be29 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Remove identity map

    hds committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c5e9d69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e52bc5 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Configuration menu
    Copy the full SHA
    2f2332e View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Apply Eliza's suggestions from code review

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    hds and hawkw committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    a14fb75 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2e00c1 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Configuration menu
    Copy the full SHA
    ce5c111 View commit details
    Browse the repository at this point in the history