Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): remove trailing space from task/resource location #443

Merged
merged 4 commits into from
Jul 3, 2023
Merged

fix(console): remove trailing space from task/resource location #443

merged 4 commits into from
Jul 3, 2023

Commits on Jul 3, 2023

  1. fix(console): remove trailing space from task/resource location 

    When a file location is formatted, an extra space is added at the end.
This appears to be the result of some refactoring from a case where we
needed the extra space at the end.

Currently, the extra space results in there being 2 spaces between the
Location column and the Fields column in the tasks list view, and the
same between the Location column and the Attributes column in the
resources list view.

It is also causing issues when attempting to truncate the first part of
the location in #441 (during which this extra space was discovered).

This change removes the trailing space.
    @hds
    hds committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    27a572d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into hds/remove-location-trailing-space

    @hds
    hds committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    bbb0161 View commit details
    Browse the repository at this point in the history

  3. Update tokio-console/src/state/mod.rs 

    Co-authored-by: Eliza Weisman <eliza@buoyant.io>
    @hds @hawkw
    hds and hawkw committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    6cb8edf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into hds/remove-location-trailing-space

    @hawkw
    hawkw committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    53b7190 View commit details
    Browse the repository at this point in the history