Drop the "unstable" feature #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually agree with this. I added this feature because io-uring was in a period of rapid development and I wasn't sure if designed interface was suitable. but now development of io-uring crate has slowed down considerably. I prefer to keep an empty feature. |
Dependent crates that rely on "unstable" functionality need to restrict the set of supported io-uring versions to a predetermined closed range (e.g. >=0.5.6, <=0.5.8), just in case a future release breaks compatibility. This makes io-uring version incompatibilities in a dependency graph more likely, and can complicate packaging for distributions (see [1] for an example). Let's rely on the fact that we're pre-1.0 to safely try out new APIs instead. Still, keep an unused "unstable" feature on the io-uring crate to avoid breaking compatibility. [1] https://bugzilla.redhat.com/show_bug.cgi?id=2124697#c76 Signed-off-by: Alberto Faria <afaria@redhat.com>
|
v2:
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to drop the "unstable" feature.
Dependent crates that rely on "unstable" functionality need to restrict the set of supported io-uring versions to a predetermined closed range (e.g. >=0.5.6, <=0.5.8), just in case a future release breaks compatibility. This makes io-uring version incompatibilities in a dependency graph more likely, and can complicate packaging for distributions (see https://bugzilla.redhat.com/show_bug.cgi?id=2124697#c76 for an example).
Let's rely on the fact that we're pre-1.0 to safely try out new APIs instead.
Since we're removing a feature, this will require a bump to 0.6.0. Alternatively, we can keep the feature but make it functionless.