Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #995

Closed
carllerche opened this issue Jun 20, 2019 · 3 comments
Closed

Refactor tests #995

carllerche opened this issue Jun 20, 2019 · 3 comments
Milestone
v0.7-alpha

Comments

@carllerche
Copy link
Member

The mio tests are still structured as they were initially many years ago. They are in need of some cleanup.

  • Remove test_ from file name
  • Remove tests/mod.rs.
  • Remove boilerplate (see this test).
  • Other cleanup.
@carllerche carllerche added this to the v0.7 milestone Jun 20, 2019
@Thomasdezeeuw
Copy link
Collaborator

I also plan to port of all tests I have in Gaea (https://github.com/Thomasdezeeuw/gaea/tree/5103cf8ae4c9e54b118f50620a43b3df4605afa4/tests).

@Thomasdezeeuw Thomasdezeeuw mentioned this issue Jul 6, 2019
Merged
@Thomasdezeeuw Thomasdezeeuw mentioned this issue Sep 12, 2019
Merged
@Thomasdezeeuw Thomasdezeeuw mentioned this issue Nov 12, 2019
Merged
@Thomasdezeeuw
Copy link
Collaborator

@carllerche I think this can be closed, or do you have more plans? #1071 is also still open.

@carllerche
Copy link
Member Author

This can be closed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7-alpha
Development

No branches or pull requests
2 participants
@carllerche @Thomasdezeeuw