Split Event::is_hup into is_hup and is_read_hup and refer to OS selector docs #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
requested changes
Jul 16, 2019
Thomasdezeeuw
commented
Jul 17, 2019
This was referenced Jul 17, 2019
Closed
And refer to the selector documentation.
Thomasdezeeuw
force-pushed
the
event-notes
branch
from
ef8f4a8
to
c42e2db
Compare
|
Rebased on master. |
Thomasdezeeuw
changed the title
carllerche
reviewed
Jul 20, 2019
carllerche
reviewed
Jul 20, 2019
| /// | [OS selector] | Flag(s) checked | | ||
| /// |---------------|-----------------| | ||
| /// | [epoll] | `EPOLLRDHUP` | | ||
| /// | [kqueue] | `EV_EOF` | |
There was a problem hiding this comment.
I think it is: EVFILT_READ with EV_EOF.
There was a problem hiding this comment.
You're right but doesn't the read part of the method name imply that? I'm fine with adding it though.
carllerche
approved these changes
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't mention Windows, I think the Windows rewrite should be merged first.
Updates #941.
Closes #1040.