Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UDS support for Unix systems #1098

Merged
merged 36 commits into from
Oct 9, 2019
Merged

Add UDS support for Unix systems #1098

merged 36 commits into from
Oct 9, 2019

Commits on Sep 27, 2019

  1. Add support for Unix Domain Sockets

    @carllerche @kleimkuhler
    carllerche authored and kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    2fb7adc View commit details
    Browse the repository at this point in the history

  2. wip

    @carllerche @kleimkuhler
    carllerche authored and kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    7b9d8f8 View commit details
    Browse the repository at this point in the history

  3. Implement rest of UDS functions 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    328ca69 View commit details
    Browse the repository at this point in the history

  4. Add first pass for UDS accept 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    d423ba9 View commit details
    Browse the repository at this point in the history

  5. Fix SocketAddr issue for now 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    19d3b0f View commit details
    Browse the repository at this point in the history

  6. Add SocketAddr impl and cleanup UDS functions 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    aed7a7a View commit details
    Browse the repository at this point in the history

  7. Add SocketAddr debug impl 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    06e79d3 View commit details
    Browse the repository at this point in the history

  8. Fix macos target_os build 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    b388647 View commit details
    Browse the repository at this point in the history

  9. Remove unncessary socket_type 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    a2b1468 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2019

  1. Add initial accept test 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    0dc16bf View commit details
    Browse the repository at this point in the history

  2. Add more HUP tests (tokio-rs#944)

    @carllerche @kleimkuhler
    carllerche authored and kleimkuhler committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    190f041 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. Add working listen, connect, and read tests 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    08b7fd3 View commit details
    Browse the repository at this point in the history

  2. Add more tests and vectored reads/writes 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    aa83c12 View commit details
    Browse the repository at this point in the history

  3. Add more tests 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Sep 30, 2019
    Configuration menu
    Copy the full SHA
    a08ca2b View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Cleanup tests 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    911d629 View commit details
    Browse the repository at this point in the history

  2. Remove picked test file 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    5afb6ba View commit details
    Browse the repository at this point in the history

  3. Fix mac build 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    cfbf4e1 View commit details
    Browse the repository at this point in the history

  4. Add macro exports 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    9adcfdc View commit details
    Browse the repository at this point in the history

  5. Consolidate pair functions 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    c518d7f View commit details
    Browse the repository at this point in the history

  6. Small change 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    cebee4b View commit details
    Browse the repository at this point in the history

  7. Format changes 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    0b9532c View commit details
    Browse the repository at this point in the history

  8. Skip accept4 for solaris and netbsd 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    7b896f8 View commit details
    Browse the repository at this point in the history

  9. Fix pointer cast 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    e2e297c View commit details
    Browse the repository at this point in the history

  10. Use libc::c_char in pointer cast 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    21e8c7f View commit details
    Browse the repository at this point in the history

  11. Remove unncessary slice function 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 1, 2019
    Configuration menu
    Copy the full SHA
    52cc394 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Reduce unsafe usage and add a few small fixes 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    80d559c View commit details
    Browse the repository at this point in the history

  2. Add SelectorId to debug_assertions 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    44fa588 View commit details
    Browse the repository at this point in the history

  3. Remove use of MaybeUninit and small renamings 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    6256d7b View commit details
    Browse the repository at this point in the history

  4. Add back use of MaybeUnint for libc::sockaddr_un struct initialization 

    This introduced problems cross-platform

Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    9976dcc View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2019

  1. Introduce sys UDS types 

    This commit introduces a significant restructure from the original UDS
support proposal. Originally, the UDS types dispatched the the `std` UDS
types from the `net` module. This was different from other `net` module
types because it did not use the `sys` modules types for that OS.

This was okay because currently UDS is only supported by Unix, but when
windows support is added this would have been a problem.

The new structure sets up most of the work for Windows UDS support as
the `net` module UDS types now all dispatch to their inner `sys` module
types.

Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    d0317d9 View commit details
    Browse the repository at this point in the history

  2. Add final review changes 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    2be1dcd View commit details
    Browse the repository at this point in the history

  3. Fix cfg in test 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    ffb2f1c View commit details
    Browse the repository at this point in the history

  4. Remove unsafe sockaddr init (test all platforms) 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    9d9cbc6 View commit details
    Browse the repository at this point in the history

  5. Revert "Remove unsafe sockaddr init (test all platforms)" 

    This did not work across all plaforms :(

This reverts commit 9d9cbc6.
    @kleimkuhler
    kleimkuhler committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    3904f10 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. Remove use of stdlib unix::SocketAddr 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    a303398 View commit details
    Browse the repository at this point in the history

  2. Change UDS test cfg 

    Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
    @kleimkuhler
    kleimkuhler committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    3145a1e View commit details
    Browse the repository at this point in the history