Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove = requirement and use cargo update --precise instead #1170

Merged
merged 1 commit into from Nov 27, 2019

Conversation

est31
Copy link

@est31 est31 commented Nov 27, 2019

Adopting the changes suggested by @cuviper in #1099 (comment) .

Fixes #1169

@Thomasdezeeuw Thomasdezeeuw merged commit fa23f6e into tokio-rs:v0.6.x Nov 27, 2019
@Thomasdezeeuw
Copy link
Collaborator

Thanks!

@carllerche this might require a new 0.6.x release.

@carllerche
Copy link
Member

If we are going to make this change, we should increase the minimum supported rust version.

@est31
Copy link
Author

est31 commented Nov 27, 2019

@carllerche why? There is no need to increase it on the 0.6.x branch too, and it is useful to have a large MSRV range.

Most people probably won't, but anyone who wants to actually use Rust 1.18 can just runcargo update --precise themselves, or if they want to, they can add a = requirement for cfg-if to their own Cargo.toml as well. Whatever mio does, it's already the case that you can't run cargo update blindly if you need to support an older Rust version, but you have to update crates one by one. So people just do cargo update -p mio.

There are further alternatives like a clone of the entire registry that contains only crates supported by a specific Rust version, or custom resolvers entirely (there exist prototypes for both). Managing MSRVs via = requirements is not good though and causes problems for everyone. Nor is increasing MSRV just for this :).

@carllerche
Copy link
Member

sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants