New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable all mio features in Rust Playground #1290
Conversation
Shouldn't this be in the features section rather than in the examples one? |
Yes, indeed. I will change that. |
I have no idea if this would work or not, is there any documentation for the playground? Couldn't it just use |
Looking at rust-lang/rust-playground#192 (comment), could we do the following? # Enable all features on the playground.
[package.metadata.playground]
all-features = true Do we have any way to to test this, besides publishing a new version and trying? |
@Thomasdezeeuw I will have a go at building and running the playground locally. |
In general, no, as it’s possible to have conflicting sets of features or features that require nightly. Of course, a crate can opt in to all features if it knows that’s feasible for itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @peterjoel! I think features
can remain how it is without setting additional metadata.
Co-Authored-By: Kevin Leimkuhler <kevin@kleimkuhler.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! |
Some common mio examples do not currently work in Rust playground (https://play.rust-lang.org/), because modules like
net
are not available with default features.