Fix error handling in NamedPipe::write #1461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This is a part of tokio-rs/tokio#3388.
I found an issue with
NamedPipe::write
, namely it hangs inWouldBlock
if other side is disconnected. The problem is in error handling:WouldBlock
without changing the state (here).Another improvement introduced in this PR is better handling of immediately finished operations. For immediately failed operations this means, that the caller won't falsely receive
Ok(usize)
. For immediately succeeded operations this means, that the caller could track the progress with better precision.