Backport fix about close-on-exec to v0.7.x #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The close-on-exec flag (FD_CLOEXEC; see fcntl(2)) for the duplicate descriptor is off and we should set it manually. Fixes: tokio-rs/tokio#3809 Signed-off-by: Tim Zhang <tim@hyper.sh>
Thomasdezeeuw
approved these changes
Jun 11, 2021
|
Thanks @Tim-Zhang. |
| @@ -41,7 +41,7 @@ impl Selector { | |||
| } | |||
|
|
|||
| pub fn try_clone(&self) -> io::Result<Selector> { | |||
| syscall!(dup(self.ep)).map(|ep| Selector { | |||
| syscall!(fcntl(self.ep, libc::F_DUPFD_CLOEXEC)).map(|ep| Selector { | |||
There was a problem hiding this comment.
I should have caught this reviewing this previously but, @Tim-Zhang you need to pass a third argument to fcntlhere. It's fixed in 2883f5c and #1498.
There was a problem hiding this comment.
sorry for the mistake, I saw you have fixed this, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #1491
The close-on-exec flag (FD_CLOEXEC; see fcntl(2)) for the duplicate descriptor is off
and we should set it manually.
Fixes: tokio-rs/tokio#3809
Signed-off-by: Tim Zhang tim@hyper.sh