Remove cfg attributes for Solaris #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
approved these changes
Nov 7, 2021
We never really supported Solaris, we pretended it implemented epoll, but it never did see tokio-rs#1152. As no one ever committed to being a maintainer for the port I'm removing it now with this commit. Instead replace it with illumuos on the CI, which we do support (as it supports epoll) and for which we do have maintainers.
The test util module requires both the "os-poll" and "net" features.
Thomasdezeeuw
force-pushed
the
remove-solaris
branch
from
b86c7d9
to
eede707
Compare
Thomasdezeeuw
added a commit
to Thomasdezeeuw/mio
that referenced
this pull request
Dec 12, 2021
Solaris support was already removed in tokio-rs#1528, but the readme still mentioned it.
Thomasdezeeuw
added a commit
that referenced
this pull request
Dec 12, 2021
Solaris support was already removed in #1528, but the readme still mentioned it.
bdbai
pushed a commit
to YtFlow/mio-noafd
that referenced
this pull request
May 15, 2022
Solaris support was already removed in tokio-rs#1528, but the readme still mentioned it.
stlankes
pushed a commit
to hermit-os/mio
that referenced
this pull request
Jun 30, 2022
Solaris support was already removed in tokio-rs#1528, but the readme still mentioned it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never really supported Solaris, we pretended it implemented epoll,
but it never did see #1152. As no
one ever committed to being a maintainer for the port I'm removing it
now with this commit.
Instead replace it with illumuos on the CI, which we do support (as it
supports epoll) and for which we do have maintainers.
Also fixes feature flags for some tests files. The test util module requires
both the "os-poll" and "net" features.