Again less truncating for timeout values in Poll::poll
#1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Round up submillisecond wait times to the next millisecond on platforms where submillisecond sleep times aren't supported. This makes the behavior actually match the documentation. See also tokio-rs#420, where this was implemented for the first time.
tbu-
force-pushed
the
pr_timeout_less_truncating2
branch
from
fbfb0f2
to
f48a6c1
Compare
|
Only for the special case of waiting between 0ms and 1ms. |
Thomasdezeeuw
approved these changes
Dec 27, 2022
|
Thanks @tbu- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round up submillisecond wait times to the next millisecond on platforms where submillisecond sleep times aren't supported. This makes the behavior actually match the documentation.
See also #420, where this was implemented for the first time.