kqueue: Ignore EPIPE coming out of kevent
#583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates mio to ignore `EPIPE` coming out of `kevent`. It turns out that older versions of OSX (10.10 and 10.11 have been confirmed) will return an `EPIPE` when registering one half of a pipe where the other half has been closed. On other platforms this is an ok operation which just returns that the pipe is readable/writable (to return an error/eof), so this brings the OSX behavior in line by ignoring the error and moving to the next event. Closes tokio-rs#582
This was referenced Apr 4, 2017
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 4, 2017
I've tracked down what I believe is the last spurious sccache failure on rust-lang#40240 to behavior in mio (tokio-rs/mio#583), and this commit updates the binaries to a version which has that fix incorporated.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 5, 2017
I've tracked down what I believe is the last spurious sccache failure on rust-lang#40240 to behavior in mio (tokio-rs/mio#583), and this commit updates the binaries to a version which has that fix incorporated.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 5, 2017
…sxcv travis: Update sccache binaries I've tracked down what I believe is the last spurious sccache failure on rust-lang#40240 to behavior in mio (tokio-rs/mio#583), and this commit updates the binaries to a version which has that fix incorporated.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 5, 2017
…sxcv travis: Update sccache binaries I've tracked down what I believe is the last spurious sccache failure on rust-lang#40240 to behavior in mio (tokio-rs/mio#583), and this commit updates the binaries to a version which has that fix incorporated.
|
Closed by #584 |
alexcrichton
added a commit
to mozilla/sccache
that referenced
this pull request
Apr 28, 2017
Contains tokio-rs/mio#583 to fix tokio-rs/mio#582, transitively fixing flakiness discovered in rust-lang/rust#40240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates mio to ignore
EPIPEcoming out ofkevent. Itturns out that older versions of OSX (10.10 and 10.11 have been
confirmed) will return an
EPIPEwhen registering one half of a pipewhere the other half has been closed. On other platforms this is an ok
operation which just returns that the pipe is readable/writable (to
return an error/eof), so this brings the OSX behavior in line by
ignoring the error and moving to the next event.
Closes #582