Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest nightly does not build 0.7.0 #526

Closed
waynenilsen opened this issue Sep 2, 2021 · 4 comments
Closed

Latest nightly does not build 0.7.0 #526

waynenilsen opened this issue Sep 2, 2021 · 4 comments

Comments

@waynenilsen
Copy link

Just to raise awareness. Patch if you want to

rustc version rustc 1.56.0-nightly (50171c310 2021-09-01)

error[E0034]: multiple applicable items in scope
   --> prost-derive/src/lib.rs:109:14
    |
109 |             .intersperse(quote!(|));
    |              ^^^^^^^^^^^ multiple `intersperse` found
    |
    = note: candidate #1 is defined in an impl of the trait `Iterator` for the type `Map<I, F>`
    = note: candidate #2 is defined in an impl of the trait `Itertools` for the type `T`
help: disambiguate the associated function for candidate #1
    |
105 ~         let tags = Iterator::intersperse(field
106 +             .tags()
107 +             .into_iter()
108 +             .map(|tag| quote!(#tag)), {
109 +         let mut _s = $crate::__private::TokenStream::new();
110 +         $crate::quote_each_token!(_s $($tt)*);
  ...
help: disambiguate the associated function for candidate #2
    |
105 ~         let tags = Itertools::intersperse(field
106 +             .tags()
107 +             .into_iter()
108 +             .map(|tag| quote!(#tag)), {
109 +         let mut _s = $crate::__private::TokenStream::new();
110 +         $crate::quote_each_token!(_s $($tt)*);
  ...

warning: unused import: `itertools::Itertools`
 --> prost-derive/src/lib.rs:9:5
  |
9 | use itertools::Itertools;
  |     ^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

For more information about this error, try `rustc --explain E0034`.
warning: `prost-derive` (lib) generated 1 warning
error: could not compile `prost-derive` due to previous error; 1 warning emitted
@stefson
Copy link

stefson commented Sep 12, 2021

rust-1.56.0-beta2 errors with the same error, as I noted when test compiling firefox with it.

@stefson
Copy link

stefson commented Sep 16, 2021

was this fixed here? edb1464

@LucioFranco
Copy link
Member

Right yes that commit should have fixed it so upgrading to 0.8 should support the latest nightly. I know some people are having trouble upgrading due to some bugs introduced in 0.8 so I plan on getting 0.9 out pretty soon here.

@LucioFranco
Copy link
Member

Because this fix is released I am going to close this issue. If there are problems going forward with 0.8/0.9 related to this feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants