Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fetch_update to support mock on 32-bit MIPS and ARMv5TE #55

Merged
merged 4 commits into from
Sep 12, 2021
Merged

Use fetch_update to support mock on 32-bit MIPS and ARMv5TE #55

merged 4 commits into from
Sep 12, 2021

Conversation

messense
Copy link
Contributor

@messense messense commented Sep 9, 2021

Fixes #54.

This was referenced Sep 9, 2021
Closed
Merged
@messense
Copy link
Contributor Author

BTW I can also add arm/arm64 target to tests in this PR, or add them in a follow-up PR if you prefer.

@tobz
Copy link
Member

tobz commented Sep 11, 2021

I think the adding the tests here is correct/important, to make sure we're not regressing behavior again. 👍🏻

@tobz
Copy link
Member

tobz commented Sep 11, 2021 •
edited
Loading

@messense Would you also want to change the MSRV from 1.45.0 to 1.51.0 in .github/workflows/ci.yml? Unrelated to your change, but apparently I missed that one of the dependencies started depending on a feature releases in 1.51.0.

@messense
Copy link
Contributor Author

@messense Would you also want to change the MSRV from 1.45.0 to 1.51.0 in .github/workflows/ci.yml? Unrelated to your change, but apparently I missed that one of the dependencies started depending on a feature releases in 1.51.0.

Done.

@messense
Copy link
Contributor Author

nightly build issue tokio-rs/prost#526

@messense
Copy link
Contributor Author

messense commented Sep 11, 2021 •
edited
Loading

It seems that prost 0.8.0 already fixed it. Needs #49

@LEXUGE LEXUGE mentioned this pull request Sep 12, 2021
Open
@messense
Copy link
Contributor Author

Looks like this test_reference_self_calibration test case is not very stable?

@tobz
Copy link
Member

tobz commented Sep 12, 2021

@messense Yeah, it's not super stable on virtual machines. I think we can merge this PR given that it's just the self-calibration test that fails, and I can address the flakiness in another PR.

@tobz tobz merged commit fb8e29e into metrics-rs:main Sep 12, 2021
@tobz
Copy link
Member

tobz commented Sep 12, 2021

@messense Thanks again for your contribution.

@messense messense deleted the mips branch September 12, 2021 14:24
@tatsuya6502 tatsuya6502 mentioned this pull request Sep 14, 2021
Open
@tobz
Copy link
Member

tobz commented Sep 16, 2021

@messense Published quanta@v0.9.3 which includes this PR.

@messense messense mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not build on MIPS and ARMv5
2 participants
@messense @tobz