Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add dep: prefix to feature dependencies #919

Merged
merged 2 commits into from
Feb 29, 2024
Merged

chore: Add dep: prefix to feature dependencies #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dff9e83
chore: Add dep: prefix to feature dependencies
tottoto Sep 16, 2023
e03111b
Merge branch 'master' into dep-prefix
LucioFranco Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ bench = false

[features]
default = ["prost-derive", "std"]
prost-derive = ["dep:prost-derive"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this feature derive?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will break existing users of the feature, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right...this is fine for now then...I didn't know cargo exposed this implicitly outside the crate itself.

no-recursion-limit = []
std = []

Expand Down
5 changes: 2 additions & 3 deletions prost-build/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ rust-version = "1.70"

[features]
default = ["format"]
format = ["prettyplease", "syn"]
# When MSRV moves to 1.60, these can change to dep:
cleanup-markdown = ["pulldown-cmark", "pulldown-cmark-to-cmark"]
format = ["dep:prettyplease", "dep:syn"]
cleanup-markdown = ["dep:pulldown-cmark", "dep:pulldown-cmark-to-cmark"]

[dependencies]
bytes = { version = "1", default-features = false }
Expand Down