Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code generation for Name trait #944

Merged

Conversation

tinrab
Copy link
Contributor

@tinrab tinrab commented Nov 17, 2023

Fixes a bug in #931.

In code generator, package field was used to track nesting of messages and didn't represented the protobuf's "package" name. Nested names are now contained in type_path and package refers to file's package.

@BKDaugherty
Copy link
Contributor

BKDaugherty commented Nov 18, 2023

Closes #946 .

(Edit: Oh lol, maybe I don't have permissions for that 🙃 )

Thanks @tinrab for both the quick fix and adding the feature to prost-build in the first place!

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco LucioFranco merged commit acc1df8 into tokio-rs:master Nov 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants