Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fq_message_name should begin with one dot #981

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: fq_message_name should begin with one dot #981

merged 1 commit into from
Feb 28, 2024

Commits on Feb 28, 2024

  1. fix: fq_message_name should begin with one dot 

    When package name is empty, but type_path is filled, the fq_message_name should begin with a single dot.

Two duplicate implementations are moved to a separate function.

A test is added that creates a sub message without a package name. The code generator uses the message name to generate a rust module path, which is invalid.

fixes: tokio-rs#843
    @caspermeijn
    caspermeijn committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    78e2226 View commit details
    Browse the repository at this point in the history