Rewrite slab making it more idiomatic

[carllerche]

he goal of the rewrite is to make the APIs more idiomatic and more in line with other types in the Rust std. Also, any existing function that wasn't necessary has been removed in favor of a smaller API surface.

[carllerche]

Good question... I forgot about this :) I should catch back up.

…

On Fri, Jun 23, 2017 at 5:06 PM Guanqun Lu ***@***.***> wrote: When will this get merged? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#35 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAYJAIn23EA0ARMr8pCmwohRffbLN76ks5sHFLygaJpZM4Mlg-V> .

[carllerche]

I forgot that I wrote this... but it looks good to me!

[peterdelevoryas]

Hello @carllerche, I was using slab prior to this change, and I found the index type parameter great, even though it might have only added a tiny amount of practical type safety to my use cases. I'm disappointed that it was removed, and while I don't expect you to revert the change, I would be curious if you had more justification for the change. Personally, I don't see how a generic index type that implements From<usize> and Into<usize> is less idiomatic than the HashSet and HashMap API's which require the key to implement Hash, but I would be very interested to know if there were some discussions elsewhere that I'm not aware of, or if you have further justification for it. Thanks!

[carllerche]

It was just more complexity that didn't seem to carry its weight. You can always decorate the slab to take your custom key type.

[peterdelevoryas]

I see, thanks for humoring me!