Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of the tokio-tls crate #7

Closed
dmolokanov opened this issue Mar 17, 2020 · 2 comments · Fixed by #8
Closed

State of the tokio-tls crate #7

dmolokanov opened this issue Mar 17, 2020 · 2 comments · Fixed by #8
Labels
help wanted Extra attention is needed

Comments

@dmolokanov
Copy link
Contributor

dmolokanov commented Mar 17, 2020

Could you please clarify what is the state of tokio-tls and difference from the current crate?

I was looking for a way to get a peer certificate for my TLS server and haven't found a way to do so with the tokio-tls which I'm using right now. But in the current crate, you merged a PR to support this in PR #6. But this crate wasn't released yet.

Now, I'm confused about which version I should use going forward. Do you have any plans to backport changes from #6 to the tokio-tls? Or as alternative to release tokio-native-tls instead? Any estimates on release date if yes?

Really appreciate any information. Thanks!

@dmolokanov
Copy link
Contributor Author

dmolokanov commented Mar 21, 2020

As we discussed in Discord the main stopper for tokio team to make all tests passed for macos. While all tests are passing on the Mojave they area failing on Catalina.

I did some digging into cert is used for smoke tests and it has following validity period

Validity
            Not Before: Aug 14 17:00:03 2016 GMT
            Not After : Aug 12 17:00:03 2026 GMT

And that is what Apple doesn't consider it secure enough because it is valid for more than 875 days. As pointed in the issue

As one option you may generate a new cert for each test-suite run.

@LucioFranco Any thoughts?

@LucioFranco LucioFranco added the help wanted Extra attention is needed label Mar 23, 2020
@LucioFranco
Copy link
Member

@dmolokanov that sounds like a good solution, I currently don't have the bandwidth to do this work, but would be happy to review PRs for it! Just ping me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants