Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access to all inner streams [tokio-native-tls] #6

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

aloucks
Copy link
Contributor

@aloucks aloucks commented Feb 26, 2020

Currently the get_ref and get_mut accessors skip over the intermediate stream which prevents access to things like TlsStream::peer_certificate. This change makes the AllowStd type public and provides a way to access all layers of the nested inner streams.

Related: tokio-rs/tokio#1383

@aloucks
Copy link
Contributor Author

aloucks commented Feb 26, 2020

The lint check is failing due to lack of cargo fmt, however when I ran it, the entire project was reformatted.

I was able to fix the compile errors for the smoke tests, but macos is still failing due to some invalid flags passed to s_server.

@LucioFranco
Copy link
Member

@aloucks looks like there is a merge conflict, if you can get that resolved we can merge!

@aloucks
Copy link
Contributor Author

aloucks commented Feb 28, 2020

I rebased and resolved the conflicts but there are some compile errors in rustls crate.

@LucioFranco LucioFranco merged commit 1c3aeb6 into tokio-rs:master Feb 28, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants