Drain remote queue before blocking. #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless this is done before blocking, sending a command over the remote channel will not be able to wake up a blocked reactor. Fixes tokio-rs#311
|
Thanks @carllerche! Can you advise on whether we should try to deploy a workaround in Rusoto until this lands in a new tokio-core release? Or is the plan to do a patch release soon-ish? |
|
@srijs i'll push it tonight. There are a couple of other issues I want to try to solve too. |
|
The fix is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless this is done before blocking, sending a command over the remote
channel will not be able to wake up a blocked reactor.
Fixes #311