Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: simplify feature flags #2942

Closed
carllerche opened this issue Oct 12, 2020 · 1 comment · Fixed by #2949
Closed

meta: simplify feature flags #2942

carllerche opened this issue Oct 12, 2020 · 1 comment · Fixed by #2949
Assignees
@taiki-e
Labels
A-tokio Area: The main tokio crate C-proposal Category: a proposal and request for comments
Milestone
v0.3

Comments

@carllerche
Copy link
Member

The current feature flags are mostly a port of the old crate layout. I believe we can reduce the number of feature flags by combining some together.

  • tcp, udp, uds -> net
  • rt-util combine with rt-core (and rename rt).
  • rt-threaded -> rt-multi-thread.
@carllerche carllerche added C-proposal Category: a proposal and request for comments A-tokio Area: The main tokio crate labels Oct 12, 2020
@carllerche carllerche added this to the v0.3 milestone Oct 12, 2020
@carllerche carllerche mentioned this issue Oct 12, 2020
Merged
@taiki-e taiki-e mentioned this issue Oct 12, 2020
Merged
@Darksonn
Copy link
Contributor

I think this is good.

@taiki-e taiki-e self-assigned this Oct 12, 2020
@taiki-e taiki-e mentioned this issue Oct 12, 2020
Merged
carllerche pushed a commit that referenced this issue Oct 12, 2020
@taiki-e
rt: simplify rt-* features (#2949)
c90681b 
tokio:

    merge rt-core and rt-util as rt
    rename rt-threaded to rt-multi-thread

tokio-util:

    rename rt-core to rt

Closes #2942
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taiki-e taiki-e

Labels
A-tokio Area: The main tokio crate C-proposal Category: a proposal and request for comments
Projects
None yet
Milestone
v0.3
Development

Successfully merging a pull request may close this issue.

rt: simplify rt-* features
3 participants
@carllerche @Darksonn @taiki-e