Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TcpStream::poll_peek to use ReadBuf #2987

Closed
Darksonn opened this issue Oct 19, 2020 · 3 comments · Fixed by #3259
Closed

Change TcpStream::poll_peek to use ReadBuf #2987

Darksonn opened this issue Oct 19, 2020 · 3 comments · Fixed by #3259
Assignees
@LucioFranco
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net
Milestone
v1.0

Comments

@Darksonn
Copy link
Contributor

Darksonn commented Oct 19, 2020 •
edited

This includes poll_peek on all of TcpStream, ReadHalf and OwnedReadHalf.

This is a breaking change, so must be done when transitioning to Tokio 1.0.
@Darksonn Darksonn added C-enhancement Category: A PR with an enhancement or bugfix. A-tokio Area: The main tokio crate M-net Module: tokio/net labels Oct 19, 2020
@Darksonn Darksonn added this to the v1.0 milestone Oct 19, 2020
@Darksonn Darksonn changed the title Change TcpStream::peek and poll_peek to use ReadBuf Change TcpStream::poll_peek to use ReadBuf Oct 19, 2020
@Darksonn
Copy link
Contributor Author

Modified to only include poll_peek to be consistent with AsyncReadExt::read that doesn't use ReadBuf either.

@zaharidichev
Copy link
Contributor

@Darksonn Can I take that one?

@Darksonn
Copy link
Contributor Author

It's better to do it later. The PR will have to sit around for a long time waiting for us to start on the v1.0 transition.

@Darksonn Darksonn mentioned this issue Oct 21, 2020
Merged
@LucioFranco LucioFranco self-assigned this Dec 10, 2020
LucioFranco added a commit that referenced this issue Dec 11, 2020
@LucioFranco
net: Update TcpStream::poll_peek to use ReadBuf
2b44296 
Closes #2987
@LucioFranco LucioFranco mentioned this issue Dec 11, 2020
Merged
LucioFranco added a commit that referenced this issue Dec 11, 2020
@LucioFranco
net: Update TcpStream::poll_peek to use ReadBuf
89481f1 
Closes #2987
carllerche pushed a commit that referenced this issue Dec 12, 2020
@LucioFranco
net: update TcpStream::poll_peek to use ReadBuf (#3259)
b01b2da 
Closes #2987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucioFranco LucioFranco

Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-net Module: tokio/net
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

net: Update TcpStream::poll_peek to use ReadBuf tokio-rs/tokio
3 participants
@Darksonn @zaharidichev @LucioFranco