Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation: LocalSet#run_until is cancel-safe #6122

Closed
bryanlarsen opened this issue Nov 1, 2023 · 0 comments · Fixed by #6147
Closed

documentation: LocalSet#run_until is cancel-safe #6122

bryanlarsen opened this issue Nov 1, 2023 · 0 comments · Fixed by #6147
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-task Module: tokio/task T-docs Topic: documentation

Comments

@bryanlarsen
Copy link

Darksson asked me to open a documentation issue in a discussion question I asked: #6121

The documentation should mention that LocalSet#run_until is cancel safe if it is passed a cancel safe future.
@bryanlarsen bryanlarsen added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Nov 1, 2023
@Darksonn Darksonn added C-bug Category: This is a bug. T-docs Topic: documentation M-task Module: tokio/task and removed C-feature-request Category: A feature request. labels Nov 1, 2023
Darksonn added a commit to Darksonn/tokio that referenced this issue Nov 12, 2023
@Darksonn
task: document cancel safety of LocalSet::run_until
4257fa9 
Closes: tokio-rs#6122
@Darksonn Darksonn mentioned this issue Nov 12, 2023
Merged
Darksonn added a commit that referenced this issue Nov 14, 2023
@Darksonn
task: document cancel safety of LocalSet::run_until (#6147)
d44e995 
Closes: #6122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-task Module: tokio/task T-docs Topic: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

task: document cancel safety of LocalSet::run_until Darksonn/tokio
2 participants
@bryanlarsen @Darksonn