Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward panic_handler to tokio::runtime::Builder #1055

Merged
merged 4 commits into from
Apr 24, 2019
Merged

Forward panic_handler to tokio::runtime::Builder #1055

merged 4 commits into from
Apr 24, 2019

Conversation

ry
Copy link
Contributor

@ry ry commented Apr 23, 2019

Exposes the panic_handler landed in #1052 to runtime users.

ghost
ghost approved these changes Apr 23, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Leaving some comments on documentation formatting.

tokio/src/runtime/threadpool/builder.rs Outdated Show resolved Hide resolved
tokio/src/runtime/threadpool/builder.rs Outdated Show resolved Hide resolved
tokio/src/runtime/threadpool/builder.rs Outdated Show resolved Hide resolved
Stjepan Glavina and others added 2 commits April 23, 2019 13:38
@ry
Copy link
Contributor Author

ry commented Apr 23, 2019

@stjepang I think I've addressed your comments.

@ry ry mentioned this pull request Apr 23, 2019
Merged
carllerche
carllerche approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done 👍

@carllerche carllerche merged commit b2b796a into tokio-rs:master Apr 24, 2019
@95th 95th mentioned this pull request Dec 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ry @carllerche