Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio-trace-core to 0.2 #1111

Merged
merged 3 commits into from
May 30, 2019

Conversation

LucioFranco
Copy link
Member

No description provided.

@carllerche
Copy link
Member

I believe you need to merge v0.1.x into here to get CI to pass?

carllerche and others added 2 commits May 29, 2019 10:47
This updates tests to track a fix applied in Mio. Previously, Mio
incorrectly fired HUP events. This was due to Mio mapping `RDHUP` to
HUP. The test is updated to correctly generate a HUP event.

Additionally, HUP events will be removed from all platforms except for
Linux. This is caused by the inability to reliably map kqueue events to
the epoll HUP behavior.
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, provided that merging the unrelated changes into 0.1.x is intentional?

@LucioFranco
Copy link
Member Author

@hawkw I believe this is the correct way since master will start to diverge and break?

@carllerche carllerche merged commit 940f2c3 into tokio-rs:v0.1.x May 30, 2019
Darksonn pushed a commit that referenced this pull request Aug 23, 2020
* net: adding examples for UnixDatagram

Adding examples to documentation for UnixDatagram

* net: document named UnixDatagrams persistence

Add documentation to indicate that named UnixDatagrams 'leak'
socket files after execution.

* net: rustfmt issue in UnixDatagram

Fixing rustfmt issue in UnixDatagram

* net: adding examples for UnixDatagram

Fixes: #2686
Refs: #1679
Refs: #1111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants