Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate AsyncWrite flushes to lower IO layers for stdout / stderr. #1528

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Propagate AsyncWrite flushes to lower IO layers for stdout / stderr. #1528

merged 1 commit into from
Sep 13, 2019

Conversation

jothan
Copy link
Contributor

@jothan jothan commented Sep 3, 2019

Motivation

This is for fixing bug #1527, this patch propagates AsyncWrite flushes to the wrapped IO layers.

Solution

A boolean is added to keep track of flushing status and poll_flush was rewritten in the style of poll_write to keep track of the extra state.

carllerche
carllerche approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 This looks good to me. Sorry for the delay.

@carllerche carllerche merged commit 5b8fc19 into tokio-rs:master Sep 13, 2019
@carllerche carllerche mentioned this pull request Sep 13, 2019
Closed
@jothan jothan deleted the fix-flush branch September 17, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jothan @carllerche