Enable buffering both reads and writes #1558
Conversation
|
The clippy error seems to be in some unrelated code? |
|
Merging master should fix the clippy failure (#1569). |
tokio-io/src/io/async_write_ext.rs
Outdated
| /// small reads and writes are batched to the underlying stream. | ||
| /// | ||
| /// See [`BufStream`] for details. | ||
| fn buffered_duplex(self) -> BufStream<Self> |
There was a problem hiding this comment.
In the past, fns that require both AsyncRead + AsyncWrite have been defined on the read half.
|
From an API point of view, I think it is common to have types that implement both Also, what are the pros / cons to adding |
|
@carllerche Originally there was no method on the extension traits. @hawkw and @LucioFranco requested it be added in #1558 (comment). I'd be happy to remove them again. Perhaps it makes sense to only expose the duplex version in the ext trait, and not the one-way versions? |
|
Personally, my vote is to leave all the constructor fns as This question comes up repeatedly, so we probably should figure out some rules of thumb so we can be consistent across the misc types. |
|
Done. |
BufWriterandBufReaderdid not previously forward the "opposite" trait (AsyncReadforBufWriterandAsyncWriteforBufReader). This meant that there was no way to have both directions buffered at once. This patch fixes that, and introduces a convenience type + constructor for this double-wrapped construct.