-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: add Barrier primitive #1571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that `rustfmt` works correctly (`cargo fmt` doesn't need this).
carllerche
reviewed
Sep 18, 2019
carllerche
reviewed
Sep 18, 2019
carllerche
reviewed
Sep 19, 2019
carllerche
reviewed
Sep 19, 2019
carllerche
reviewed
Sep 19, 2019
carllerche
reviewed
Sep 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the n == 0
question.
Thanks 👍
carllerche
approved these changes
Sep 19, 2019
dignifiedquire
added a commit
to dignifiedquire/async-std
that referenced
this pull request
Sep 25, 2019
Based on the implementation in tokio-rs/tokio#1571
1 task
dignifiedquire
added a commit
to dignifiedquire/async-std
that referenced
this pull request
Sep 25, 2019
Based on the implementation in tokio-rs/tokio#1571
bors bot
added a commit
to async-rs/async-std
that referenced
this pull request
Sep 26, 2019
240: feat: implement sync::Barrier r=yoshuawuyts a=dignifiedquire ~~Based on the implementation in tokio-rs/tokio#1571 Based on the implementation in the std lib Things to discuss - `async` or `std` `Arc` in examples and tests - ~~`async` or `std` `Mutex` in the implementation~~ can't use std, as it needs to be shared - use of `broadcaster` dependency to implement, well broadcast To fix - [x] missing debug implementation, once broadcaster has it, or it is dropped ## Docs ![Screenshot 2019-09-25 at 21 07 25](https://user-images.githubusercontent.com/790842/65631833-a541e580-dfd8-11e9-970b-8a1df9155529.png) Co-authored-by: dignifiedquire <dignifiedquire@users.noreply.github.com>
bors bot
added a commit
to async-rs/async-std
that referenced
this pull request
Sep 26, 2019
240: feat: implement sync::Barrier r=yoshuawuyts a=dignifiedquire ~~Based on the implementation in tokio-rs/tokio#1571 Based on the implementation in the std lib Things to discuss - `async` or `std` `Arc` in examples and tests - ~~`async` or `std` `Mutex` in the implementation~~ can't use std, as it needs to be shared - use of `broadcaster` dependency to implement, well broadcast To fix - [x] missing debug implementation, once broadcaster has it, or it is dropped ## Docs ![Screenshot 2019-09-25 at 21 07 25](https://user-images.githubusercontent.com/790842/65631833-a541e580-dfd8-11e9-970b-8a1df9155529.png) Co-authored-by: dignifiedquire <dignifiedquire@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Barrier
totokio-sync
, which is an asynchronous alternative tostd::sync::Barrier
. It is a synchronization primitive that allows multiple futures to "rendezvous" at certain points in their execution. An example execution might look like this (included in the docs):