DelayQueue::len #1755
Merged
DelayQueue::len #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. We have been busy! Could you merge master? Also, could you limit the Pr to the len fn? How to handle Fused is not figured out yet. Once we do, we can update everything across Tokio. |
|
Force-pushed a rebased version without |
|
woops, looks like somehow CI isn't passing. I will open an issue. |
|
Issue is #1895 |
|
The PR looks good, the doc example needs to be updated to pass CI 👍 |
|
Give me a few days to fix this, I have some hardware issues atm. |
|
Sorry that it took some time; this one is actually tested and should™ pass CI :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some commits for unimplemented things in the
DelayQueue.Solution
Add a
DelayQueue::len()Sometimes it's useful to keep track of how many items we still have in the queue.
ImplementFusedStreamforDelayQueueI'm not sure that this is a correct implementation, cfr #1754, and I'll gladly change the commit to reflect any other needed change.Change removed