Add split method to UnixDatagram #1757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jean-airoldie
force-pushed
the
split_uds
branch
from
194601d
to
e84cfdf
Compare
|
Thanks 👍 his is great. Unfortunately, the PR needs to be updated to merge into master, but the change looks good to me. The main difference is that |
jean-airoldie
force-pushed
the
split_uds
branch
2 times, most recently
from
05450ff
to
7e4127f
Compare
This adds a split method for `UnixDatagram` as well as the SendHalf and RecvHalf types. This allows a user to both receive and send datagram at the same time on the same socket.
jean-airoldie
force-pushed
the
split_uds
branch
from
7e4127f
to
f085e36
Compare
Darksonn
added
A-tokio
|
Closing in favor of #2687. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This allows a user to both
receive and send datagram at the same time on the same socket.
Solution
This adds a split method for
UnixDatagramas well as theSendHalf and RecvHalf types. This essentially the same principle that is applied for
ReadHalfandWriteHalfreturned by theUnixStream::splitmethod.