task: fix LocalSet failing to poll all local futures
#1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Currently, a `LocalSet` does not notify the `LocalFuture` again at the end of a tick. This means that if we didn't poll every task in the run queue during that tick (e.g. there are more than 61 tasks enqueued), those tasks will not be polled. This commit fixes this issue by changing `local::Scheduler::tick` to return whether or not the local future needs to be notified again, and waking the task if so. Fixes #1899 Fixes #1900 Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, a
LocalSetdoes not notify theLocalFutureagain at theend of a tick. This means that if we didn't poll every task in the run
queue during that tick (e.g. there are more than 61 tasks enqueued),
those tasks will not be polled.
Solution
This commit fixes this issue by changing
local::Scheduler::ticktoreturn whether or not the local future needs to be notified again, and
waking the task if so. I've also added a test that reproduces this.
Thanks @carllerche for figuring this out!
Fixes #1899
Fixes #1900
Signed-off-by: Eliza Weisman eliza@buoyant.io