Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: print MutexGuard inner value for debugging #1961

Merged
merged 2 commits into from
Dec 18, 2019
Merged

sync: print MutexGuard inner value for debugging #1961

merged 2 commits into from
Dec 18, 2019

Conversation

yim7
Copy link
Contributor

@yim7 yim7 commented Dec 14, 2019

We usually want to print values that smart pointers point to when formatting, liking the behavior in the std.

carllerche
carllerche requested changes Dec 14, 2019
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 minor nit inline for consistency w/ the rest of the tests.

tokio/tests/sync_mutex.rs Outdated Show resolved Hide resolved
@yim7 yim7 requested a review from carllerche December 15, 2019 16:17
carllerche
carllerche reviewed Dec 18, 2019
View reviewed changes
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit e5b99b0 into tokio-rs:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yim7 @carllerche