Stream filtering facilities #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
reviewed
Dec 20, 2019
hawkw
approved these changes
Dec 21, 2019
| /// will be run against them. If the predicate | ||
| /// resolves to `true`, then the stream will yield the value, but if the | ||
| /// predicate resolves to `false`, then the value | ||
| /// will be discarded and the next value will be produced. |
There was a problem hiding this comment.
Do you think it's worth highlighting that this differs from futures-rs's version, in that it takes a synchronous predicate?
There was a problem hiding this comment.
nah, i think that would add confusion.
Comment on lines
+141
to
+142
| /// [`Some(item)`](Some) then the stream will yield the value `item`, but if | ||
| /// it resolves to [`None`] then the next value will be produced. |
There was a problem hiding this comment.
They should, see !Unpin here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
StreamExt::filterandStreamExt::filter_mapwhich allow filtering and mapping items yielded by the wrapped stream.Unlike the version in #1962 combinators presented here accept synchronous predicates which do immediate check upon receiving items from inner stream. The necessity and design of versions for asynchronous predicate is a subject of a further discussion.