-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Stream
for broadcast::Receiver
#2012
Conversation
This is probably going to require a merge master / update once #2007 lands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
I'll keep track of it and update this PR once that lands. |
Mind merging? |
Done |
I'm not entirely sure why the rustfmt job is failing, as running it locally doesn't show any changes. |
Because We should add a script in our repo to run fmt... CI uses this: https://github.com/tokio-rs/tokio/blob/master/ci/azure-rustfmt.yml#L17 |
Oh, could you add a test that goes via the It mostly will be copying an existing test but then explicitly calling |
Great work! Thanks |
Motivation
The broadcast
Receiver
doesn't have aStream
impl.Solution
Implement
Stream
forbroadcast::Receiver