Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: deprecate Child stdio accessors in favor of pub fields #2014

Merged
merged 1 commit into from
Jan 6, 2020
Merged

process: deprecate Child stdio accessors in favor of pub fields #2014

merged 1 commit into from
Jan 6, 2020

Conversation

ipetkov
Copy link
Member

@ipetkov ipetkov commented Dec 21, 2019

Motivation

The current strategy of accessing Child stdio handles via accessors does not allow for mutably borrowing over multiple stdio handles.

Solution

Deprecate stdio accessors in favor of public fields. The Child struct still has a private member, so we can add additional fields without breaking changes

Fixes #2009

@carllerche
Copy link
Member

Looks great to me 👍 thanks for the fast turn around. I requested a review from @sfackler (just to make sure he doesn't see any backwards compat issues).

Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit 188fc6e into tokio-rs:master Jan 6, 2020
@ipetkov ipetkov deleted the process-stdio branch January 7, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tokio::process::Child stdin/stdout/stderr public fields to allow for split borrows
2 participants