util: add futures-io/tokio::io compatibility layer #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a compatibility layer with conversions between the `tokio::io` and `futures-io` versions of the `AsyncRead` and `AsyncWrite` traits. I initially opened this PR against `tokio-compat`, but we decided that a compatibility layer for current versions of the `tokio` and `futures-io` crates (rather than for compatibility with legacy code) ought to go in `tokio-util` instead. See: tokio-rs/tokio-compat#2 (comment) This is based on code originally written by @Nemo157 as part of the `futures-tokio-compat` crate, and is contributed on behalf of the original author: Nemo157/futures-tokio-compat#2 (comment) Closes tokio-rs/tokio-compat#2 Co-authored-by: Wim Looman <wim@nemo157.com> Signed-off-by: Eliza Weisman <eliza@buoyant.io>
LucioFranco
approved these changes
Jan 15, 2020
taiki-e
reviewed
Jan 20, 2020
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
taiki-e
reviewed
Jan 29, 2020
taiki-e
approved these changes
Jan 29, 2020
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
|
Hi folks! Any plans for a new tokio-util release with this feature? |
|
@dtantsur hopefully this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a compatibility layer with conversions between the
tokio::ioandfutures-ioversions of theAsyncReadandAsyncWritetraits.I initially opened this PR against
tokio-compat, but we decided thata compatibility layer for current versions of the
tokioandfutures-iocrates (rather than for compatibility with legacy code)ought to go in
tokio-utilinstead. See:tokio-rs/tokio-compat#2 (comment)
This is based on code originally written by @Nemo157 as part of the
futures-tokio-compatcrate, and is contributed on behalf of theoriginal author:
Nemo157/futures-tokio-compat#2 (comment)
Closes tokio-rs/tokio-compat#2
Co-authored-by: Wim Looman wim@nemo157.com
Signed-off-by: Eliza Weisman eliza@buoyant.io